🛡️ Sentinel: [HIGH] Fix XSS vulnerability in email preview - #349
🛡️ Sentinel: [HIGH] Fix XSS vulnerability in email preview#349brycejohnson1417 wants to merge 1 commit into
Conversation
…erHTML with a sandboxed iframe Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: HIGH
💡 Vulnerability: The PPP savings email preview was rendered using
dangerouslySetInnerHTML. Although sanitized with DOMPurify, rendering dynamic HTML directly into the DOM poses an XSS risk and can cause styling side-effects.🎯 Impact: If malicious HTML bypassing DOMPurify was injected, it could execute scripts in the context of the application.
🔧 Fix: Replaced
dangerouslySetInnerHTMLwith aniframeusing thesrcDocattribute. Applied a strictsandbox="allow-popups allow-popups-to-escape-sandbox"policy to isolate the content and prevent script execution while allowing link clicks. Injected base styles to maintain visual parity.✅ Verification: Ran full static checks, tenant isolation checks, and verified the UI rendering using Playwright. No regressions observed.
PR created automatically by Jules for task 13176841026022260840 started by @brycejohnson1417