π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in email preview - #342
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in email preview#342brycejohnson1417 wants to merge 1 commit into
Conversation
Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
π¨ Severity: HIGH
π‘ Vulnerability: Used
dangerouslySetInnerHTMLfor rendering email previews.π― Impact: Potential Cross-Site Scripting (XSS) if DOMPurify fails to catch a bypass, leading to unauthorized actions.
π§ Fix: Replaced
dangerouslySetInnerHTMLwith a sandboxediframeusingsrcDocfor defense-in-depth isolation. Added inline styles to preserve appearance.β Verification: Ran lint, typecheck, tenant isolation checks, and verified the UI via Playwright browser tests.
PR created automatically by Jules for task 16880957663581033798 started by @brycejohnson1417