🛡️ Sentinel: [HIGH] Prevent XSS in dynamic email rendering - #341
🛡️ Sentinel: [HIGH] Prevent XSS in dynamic email rendering#341brycejohnson1417 wants to merge 1 commit into
Conversation
* Replaced dangerouslySetInnerHTML with a sandboxed iframe to safely render untrusted dynamic email HTML. * Set sandbox="allow-popups allow-popups-to-escape-sandbox" to allow link clicking while preventing scripts. * Injected styles into the srcDoc to preserve original typography. * Added security learnings to .jules/sentinel.md. Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21238300b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const sanitizedEmailHtml = useMemo(() => { | ||
| if (!report?.email.html) return ""; | ||
| const cleanHtml = DOMPurify.sanitize(report.email.html); | ||
| return `<style>body { font-family: sans-serif; color: black; margin: 0; padding: 24px; }</style>${cleanHtml}`; |
There was a problem hiding this comment.
When the browser supports ClipboardItem, copyDraft() writes this same sanitizedEmailHtml as the clipboard's text/html. The new <style>body { ... margin: 0; padding: 24px; }</style> is only needed to pad the sandboxed preview, but it will be pasted into the outbound email too, so copied PPP drafts can get an extra body reset/padding or have the style tag stripped unpredictably by the mail client. Split preview HTML from clipboard HTML so copying preserves the generated email markup.
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Used
dangerouslySetInnerHTMLto render dynamic HTML content, posing an XSS risk.🎯 Impact: Attackers could bypass sanitization and execute malicious scripts or manipulate application UI.
🔧 Fix: Replaced
dangerouslySetInnerHTMLwith a sandboxediframeusingsrcDocandsandbox="allow-popups allow-popups-to-escape-sandbox".✅ Verification: Verified the file contents, passed lint/typecheck, and visually inspected the iframe rendering in the frontend.
PR created automatically by Jules for task 7655700761206926062 started by @brycejohnson1417