Skip to content

馃帹 Palette: Add aria-controls to change request accordion #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brycejohnson1417 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

馃帹 Palette: Add aria-controls to change request accordion #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-07-01 - Add aria-controls to conditionally rendered accordions
**Learning:** When an accordion's content is conditionally rendered in React (e.g., `{expanded ? <div>...</div> : null}`), adding `aria-controls` to the trigger button will point to a non-existent ID when collapsed, breaking screen reader association.
**Action:** Always provide an empty persistent container with the `id` (e.g., `<div id={contentId}>{expanded ? <Content /> : null}</div>`) or apply the `id` to both branches of a ternary to ensure the association remains unbroken.
Loading
Loading