🛡️ Sentinel: [security improvement] - #336
Conversation
Switched the dynamic email preview rendering in ppp-savings-panel.tsx from using `dangerouslySetInnerHTML` to a sandboxed `<iframe srcDoc>`. This significantly mitigates XSS risk even when using DOMPurify by moving the untrusted HTML out of the parent browsing context. Included inline CSS in the `srcDoc` template to preserve existing visual fidelity. Co-authored-by: brycejohnson1417 <257422776+brycejohnson1417@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Used dangerouslySetInnerHTML for rendering dynamic email HTML. Even with DOMPurify, this poses a risk as the HTML context is still shared with the main application document.
🎯 Impact: Potential XSS attacks if DOMPurify fails to catch an exploit or is misconfigured, leading to session hijacking or unauthorized actions within the app context.
🔧 Fix: Replaced dangerouslySetInnerHTML with a sandboxed iframe using the srcDoc attribute (sandbox="allow-popups allow-popups-to-escape-sandbox"). Added inline CSS via srcDoc to maintain original visual fidelity.
✅ Verification: Manual verification via Playwright screenshot. Automated linting, typechecking, and smoke tests passed.
PR created automatically by Jules for task 8562780352938793696 started by @brycejohnson1417