update Received headers for rfc8314 (tls trace)#4
Open
rtdean wants to merge 1 commit into
Open
Conversation
RFC8314 outlines the use of TLS for email submission, access, and transport. As a part of this, in section 4.3, they build on the trace capability defined in RFC3848 for recording the ciphersuite and dh group information in the Received trace header. While working to modernize a qmail stack using mailfront, I noticed that mailfront didn't emit any type of TLS trace headers today, unlike the qmail-smtpd tls patch that had been in use. This attempts to bridge that gap (lack of TLS trace information in Received headers) in a RFC-compliant way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC8314 outlines the use of TLS for email submission, access, and transport. As a part of this, in section 4.3, they build on the trace capability defined in RFC3848 for recording the ciphersuite and dh group information in the Received trace header.
While working to modernize a qmail stack using mailfront, I noticed that mailfront didn't emit any type of TLS trace headers today, unlike the qmail-smtpd tls patch that had been in use.
This attempts to bridge that gap (lack of TLS trace information in Received headers) in a RFC-compliant way.
As for why
gnutls_ciphersuite_get(), 8314 indicated that they really wanted the IANA-registered TLS ciphersuite string, andgnutls_ciphersuite_getprovided that. If it doesn't exist (gnutls too old), it just degrades into not adding the TLS trace information.