Skip to content

Fix/consensus/config change#1092

Open
Mododo wants to merge 2 commits into
masterfrom
fix/consensus/config-change
Open

Fix/consensus/config change#1092
Mododo wants to merge 2 commits into
masterfrom
fix/consensus/config-change

Conversation

@Mododo
Copy link
Copy Markdown
Member

@Mododo Mododo commented May 29, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

None

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

Added focused Cache unit test

Network Tests

No coverage

Manual Tests

transfers-30k with consensus config change


Notes/Additional Comments:

@Mododo Mododo added this to the 020 Consensus milestone May 29, 2026
@Mododo Mododo requested review from 0xdeafbeef, Rexagon and SmaGMan May 29, 2026 20:18
@Mododo Mododo self-assigned this May 29, 2026
@Mododo Mododo added C-collator Collator module C-consesus Consesus module labels May 29, 2026
@github-actions
Copy link
Copy Markdown

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1092

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1092
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1092 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@Mododo Mododo enabled auto-merge May 29, 2026 20:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 70.14925% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.04%. Comparing base (4bcbe5f) to head (d8faf1b).

Files with missing lines Patch % Lines
collator/src/mempool/impls/common/cache.rs 77.04% 13 Missing and 1 partial ⚠️
consensus/src/engine/lifecycle/session.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
- Coverage   59.07%   59.04%   -0.03%     
==========================================
  Files         465      465              
  Lines       77220    77267      +47     
  Branches    77220    77267      +47     
==========================================
+ Hits        45620    45625       +5     
- Misses      29473    29512      +39     
- Partials     2127     2130       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-collator Collator module C-consesus Consesus module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant