Skip to content

feat(network): add check any bootstrap node is alive on start#1060

Open
serejkaaa512 wants to merge 1 commit into
masterfrom
feature/check-bootstrap-on-start
Open

feat(network): add check any bootstrap node is alive on start#1060
serejkaaa512 wants to merge 1 commit into
masterfrom
feature/check-bootstrap-on-start

Conversation

@serejkaaa512
Copy link
Copy Markdown
Contributor

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

[None]

BLOCKCHAIN CONFIGURATION MODEL CHANGES

[None]

COMPATIBILITY

[Yes]

SPECIAL DEPLOYMENT ACTIONS

[Not Required]

PERFORMANCE IMPACT

[Expected impact]

Start may be delayed for connection timeout to all bootstrap nodes.

TESTS

Unit Tests

[No coverage]

Network Tests

[No coverage]

Manual Tests

[Manual tests used]

[No coverage]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=1060

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=1060
  • Run specific test: gh workflow run network-tests.yml -f pr_number=1060 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@serejkaaa512 serejkaaa512 linked an issue Mar 26, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.23%. Comparing base (577e65b) to head (5c901bf).

Files with missing lines Patch % Lines
core/src/node/mod.rs 0.00% 25 Missing ⚠️
cli/src/node/mod.rs 0.00% 3 Missing ⚠️
network/src/network/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage   57.23%   57.23%   -0.01%     
==========================================
  Files         429      429              
  Lines       71848    71876      +28     
  Branches    71848    71876      +28     
==========================================
+ Hits        41125    41139      +14     
- Misses      28733    28749      +16     
+ Partials     1990     1988       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@serejkaaa512 serejkaaa512 force-pushed the feature/check-bootstrap-on-start branch from c7a6267 to 5c901bf Compare March 26, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fail loudly if we can't resolve nodes in global config

1 participant