AXE-3659 R0: pin fork behaviors ahead of the staged 4.12.1 upgrade (tests only)#250
Open
rohitsahu-bstack wants to merge 1 commit into
Open
AXE-3659 R0: pin fork behaviors ahead of the staged 4.12.1 upgrade (tests only)#250rohitsahu-bstack wants to merge 1 commit into
rohitsahu-bstack wants to merge 1 commit into
Conversation
Adds isolated, classic-style karma tests characterizing fork behaviors that had zero coverage, so the deferred upstream grafts cannot silently regress them: color-contrast reviewPayload + try/catch/addCheckError; dq-element htmlHash + data-percy source strip + runTypeAOpt/targetFormat branches; get-ancestry Percy :nth-child skip; is-in-text-block STYLE-skip; label-content stemming + whitespace-insensitive match + reviewPayload. All 13 green on the fork baseline (target lib files byte-identical fcb6d96..HEAD). Ref: AXE-3659
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R0 of the AXE-3659 incremental upgrade plan — tests only, zero behavior change.
Adds 13 pinning tests (5 files) characterizing fork-only behaviors that previously had zero coverage, so the upcoming staged axe-core 4.11→4.12.1 merges (R1: v4.11.1 → engine 6.5.0, R2: v4.11.4 → 6.6.0, R3: v4.12.1 → 7.0.0) cannot silently regress them:
reviewPayload.visualHelperData(+100-char truncation) and the whole-body try/catch →addCheckError(AXE-2707 resilience)htmlHashfingerprint,data-percy-*source stripping,runTypeAOpt/targetFormat=ancestrysource & selector branchesdata-percy-injected:nth-childskip<style>-element skipreviewPayloadAll tests are classic-style karma (no ESM), runnable isolated via
npm run test:unit -- testFiles=...and in the full suite.Why land this before any merge
These are the regression guard for every subsequent slice. Landing them first means the guard exists before any upstream content moves (plan:
docs/tech-specs/AXE-3659-incremental-release-plan.mdin the a11y-engine repo; the one-shot merge PR #249 remains as the end-state reference).Validation
7532cb51); pinned lib files verified byte-identical between this base (c2feddeb) and the merge branch.npm ci(current main lockfile, esbuild 0.28.1) +npm run buildfrom main's lib (Node 22): green,axe.min.js623.69 KB.Ref: AXE-3659
🤖 Generated with Claude Code