feat: add video environment preflight - #129
Draft
jbdrak wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Adds a dependency-free preflight command for video-use:
It checks:
ffmpegandffprobeare available and version 4+<videos_dir>/edit/output directory can be created and written to--requireIt exits non-zero when a required check fails. It doesn't install packages or contact external services.
Closes #121.
Why This Approach
The repository has no runtime dependency on a specific CLI framework and no existing test suite, so the command uses only the Python standard library. Optional animation engines stay opt-in because video-use installs them lazily per animation slot.
The check writes and removes a temporary file in the target directories instead of relying only on permission bits, which reflects the real failure mode on macOS, Linux, and WSL.
Documentation
install.mdnow uses the preflight command during setup verification.SKILL.mdnow recommends it on cold start and documents optional backend checks.Verification
python3 -m unittest discover -s tests -v: 9 passedpython3 -m py_compile helpers/check_env.py tests/test_check_env.py: passedpython3 -m compileall -q helpers tests: passedpython3 helpers/timeline_view.py --help: passededit/createdgit diff --check: passedScope / Non-Goals