Skip to content

Improve skill quality: phase 0 fix, failure modes, tmp isolation, layered triggers, session cleanup - #13

Closed
opensouth21 wants to merge 1 commit into
browser-act:mainfrom
opensouth21:improve/skill-quality-v1
Closed

Improve skill quality: phase 0 fix, failure modes, tmp isolation, layered triggers, session cleanup#13
opensouth21 wants to merge 1 commit into
browser-act:mainfrom
opensouth21:improve/skill-quality-v1

Conversation

@opensouth21

Copy link
Copy Markdown

Quality improvement pass on 2 core SKILL.md files and 1 reference template. 3 files changed, 191 insertions, 13 deletions.

Changes

browser-act/SKILL.md

  • Split description into layered triggers: 500-char wall of text -> description + 11 triggers entries
  • Added Pre-flight Check: auto-run on load, verifies CLI, version, and core guide integrity
  • Added 4 Failure Modes: FM-1 (CLI not installed), FM-2 (output truncated), FM-3 (session leak), FM-4 (auth failure)

browser-act-skill-forge/SKILL.md

  • Fixed Phase 0: Removed 'Already completed -> skip'. Replaced with real 3-level detection
  • Added 6 Failure Modes: FM-F1 to FM-F6
  • Per-instance tmp isolation: shared tmp/ -> tmp/{skill-name}-{datetime}/

output_template.md

  • Added Session Cleanup section to generated SKILL.md

Design note

Install command left flexible because PyPI version (1.0.5) differs from schema version (2.0.2). Runtime compatibility via CLI built-in handshake.

…, layered triggers, session cleanup

3 files changed, 191 insertions(+), 13 deletions(-)

Changes:
- browser-act/SKILL.md: Split description into layered triggers,
  add Pre-flight Check (CLI → core guide → version), add 4 failure
  modes (install, truncation, session leak, auth)
- browser-act-skill-forge/SKILL.md: Replace 'Already completed→skip'
  with full 3-level tool detection (CLI→version→key), add 6 failure
  modes (CLI, key, exploration cap, generation, test, tmp conflict),
  per-instance tmp directories
- output_template.md: Add Session Cleanup section to generated SKILL.md

Note: install command kept flexible (no version pin) because PyPI version
(1.0.5) differs from SKILL.md schema version (2.0.2). Runtime version
compatibility is enforced via CLI's built-in handshake.
@browseract-ai

Copy link
Copy Markdown
Contributor

Thank you for the contribution. The PR contains several useful ideas, particularly session
cleanup, temporary-directory isolation, and clearer failure-mode documentation.

However, we cannot merge it as-is because some changes introduce compatibility and safety
concerns, including:

  • Treating Skill version 2.0.2 as the CLI package version.
  • Moving discovery keywords from the standard description field to a non-standard triggers
    field.
  • Closing sessions without respecting cross-conversation ownership.
  • Automatically installing the CLI without explicit user confirmation.
  • Using undefined or non-portable shell variables and commands.

For future contributions, could you please split independent changes into several smaller,
focused PRs? This will make each change easier to evaluate, test, and merge separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants