Chore/update release naming - #421
Merged
Merged
Conversation
… instead of relying on the name having it
victorsowa12
commented
Sep 3, 2026
| pathlib.Path(args.out_dir).mkdir(parents=True, exist_ok=True) | ||
|
|
||
| builder.out_dir = args.out_dir | ||
| builder.out_dir = os.path.abspath(args.out_dir) |
Collaborator
Author
There was a problem hiding this comment.
this helped me to be able to run auto_build.py locally. Otherwise an eventual scp command would return with a could not find directory error. I'm unsure if it will break the github runner, I don't think so, but would love a second opinion.
victorsowa12
commented
Sep 3, 2026
Comment on lines
+204
to
+210
| output_name = "" | ||
| if config["args"]["build_type"]: | ||
| output_name = f"{config["name"]}-{config["args"]["build_type"].lower()}" | ||
| else: | ||
| output_name = config["name"] | ||
|
|
||
| cmd += ["--output-name", output_name] |
Collaborator
Author
There was a problem hiding this comment.
this is where we will now append the build_type to the name of the output artifacts. Previously it used the "name".
matt001k
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Changes the naming of release artifacts to follow:
{name}-{build_type}-{version}. This makes sure that the artifacts follow a pattern and does not require us to remember to put "_release" or "-release" in the name of the config.How does it make Bristlemouth better?
Removes our need to remember naming conventions.
Where should reviewers focus?
Testing:
Here is the resulting names after I ran auto_build.py locally on my machine:
Checklist