Feature/ftp - #419
Draft
victorsowa12 wants to merge 5 commits into
Draft
Conversation
… a bug in nvm that causes the size check to be too large - but this commit allows us to test file transfer larger than the chunk size, showing that they work!
victorsowa12
commented
Aug 15, 2026
|
|
||
| bool NvmPartition::crc16(uint32_t offset, size_t len, uint16_t &crc, uint32_t timeoutMs) { | ||
| configASSERT(offset + len + (len % _storage_driver.getAlignmentBytes()) < _partition.fa_size); | ||
| configASSERT(offset + len < _partition.fa_size); |
Collaborator
Author
There was a problem hiding this comment.
not sure if this is an actual bug, but it prevented 2560 from being read/written to in the nvm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
How does it make Bristlemouth better?
Where should reviewers focus?
Checklist