Draft
Conversation
Author
|
Draft as untested and possibly a lot of nonsense... :-) |
Author
|
Actually, fusepy has been removed from debian too. Not sure what to do to get it into debian now :-). |
Author
|
closing in favour of #5 |
obbardc
force-pushed
the
wip/obbardc/migrate-to-fusepy
branch
from
3523fb4 to
9e986c3
Compare
obbardc
changed the title
Author
|
@brgl I have an initial implementation, can you review and test ? It may be a lot of nonsense too ;-) |
Owner
|
How did you test it? The following command-line |
Author
I didn't test it. Oops.
Yeah, I added a commit to fix that. I guess we can squash them eventually once all the problems are ironed out. |
fuse-python depends on libfuse2 which is being phased out from most distros because FUSE 3 has been the stable upstream for nearly a decade and distros don't want to ship two major versions of the same library indefinitely. Because of this fuse-python is no longer packaged in Debian. Replace the usage of fuse-python with pyfuse3 which uses an inode-based async API backed by trio. Fixes: brgl#5 Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
- Accept and ignore -f/--foreground: pyfuse3 always runs in the
foreground since the event loop is managed by the caller via trio
- Silently drop 'nonempty': FUSE 3 removed this option; mounting over
a non-empty directory is unconditionally allowed
- Intercept entry_timeout=N and attr_timeout=N: these are no longer
FUSE mount options in FUSE 3; they are per-entry fields in
EntryAttributes, so parse them into globals used at entry creation
time instead of forwarding them to pyfuse3.init()
This makes the existing systemd ExecStart line work unchanged:
gpiod-sysfs-proxy /sys/class/gpio -f -o nonempty -o allow_other \
-o default_permissions -o entry_timeout=0 -o attr_timeout=0
Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
obbardc
force-pushed
the
wip/obbardc/migrate-to-fusepy
branch
from
71b307d to
4ecf1f9
Compare
Owner
|
Most tests pass, there are a couple issues: |
Author
|
sidenote, how do you run these tests ? I wonder if it would be possible for us to add them into GitHub actions CI. |
Owner
|
With yocto ptests. Use current meta-openembedded master and the following options: And the following layers: Run with runqemu and call |
Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
Author
|
@brgl I added a quick fix for the tests. Can you retry the test suite please and report back ? I haven't had the time to run it yet. I will do if there are many more issues. |
Owner
|
Some of them got fixed: |
Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
Author
|
@brgl I pushed another change. I didn't get the test setup created yet. I'll have another go at that shortly. |
Owner
Something's still missing. :/ Sorry I can't assist you more than that but I'm really swamped with work ATM. I probably won't make time for debugging it anytime soon. It would be best if you could create a VM with the options I posted above, that makes testing super easy. The results are in |
Owner
|
I tried to get claude to fix the problem and it says that pyfuse3 does not implement the poll notify mechanism fuse-python has. Is this correct? FWIW you call |
Author
Yes, I think that is correct :/. I didn't really check this code much, it's untested from my side since I couldn't yet run the test suite (see #7) fuse-python exposes that through I think we need add this functionality to pyfuse3 upstream. I will try to open a PR/issue upstream: https://github.com/libfuse/pyfuse3 |
obbardc
commented
May 5, 2026
| self._event = True | ||
| self.parent.parent.notify_poll(self._pollhandle) | ||
| self._pollhandle = None | ||
| pyfuse3.notify_poll(self._poll_handle) |
Author
There was a problem hiding this comment.
This function doesn't exist in pyfuse3. See #4 (comment)
Author
There was a problem hiding this comment.
@brgl I opened libfuse/pyfuse3#139 to discuss it upstream.
Owner
|
FYI Claude offered to implement this as a solution to the above, does pyfuse3 accept AI-assisted contributions? I can't really spend time doing it myself but if it can do a good enough job, I can send it for review. |
Author
I am happy to implement this as long as you can review the changes here and don;t mind waiting for me to have some "free time" :-) |
Owner
Sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fuse-python depends on libfuse2 which is being phased out from most
distros because FUSE 3 has been the stable upstream for nearly a decade
and distros don't want to ship two major versions of the same library
indefinitely. Because of this fuse-python is no longer packaged in
Debian.
Replace the usage of fuse-python with pyfuse3 which uses an inode-based
async API backed by trio.
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1125204