fix(vm): bind memory timestamps and harden ecrecover hooks - #105
Open
WindOctober wants to merge 2 commits into
Open
fix(vm): bind memory timestamps and harden ecrecover hooks#105WindOctober wants to merge 2 commits into
WindOctober wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryReadWriterows currently match CPU load/store instructions without includingchunkandclk, allowing the memory table to use an execution time different from the corresponding CPU row. This change appends(chunk, clk)to both sides of the lookup so each ordinary load/store transition is bound to the CPU row's constrained execution time.The ECRecover hook currently assumes guest-provided field and scalar encodings are canonical and can panic while decoding or inverting invalid inputs. This change replaces those assumptions with checked conversions and returns the hook's existing failure response for invalid encodings. VM and AOT execution now share the same implementation so both paths apply identical validation.