Skip to content

Fixed all NANs when genes with all zeros. #11#12

Open
zqfang wants to merge 3 commits into
brentp:masterfrom
zqfang:master
Open

Fixed all NANs when genes with all zeros. #11#12
zqfang wants to merge 3 commits into
brentp:masterfrom
zqfang:master

Conversation

@zqfang

@zqfang zqfang commented Dec 29, 2018

Copy link
Copy Markdown

I have the same issue that " DataFrame contains rows which are entirely zero the result returned by combat() will contain all NaNs".
May be it's a good choice to drop these entirely zeros, because all zeros could no be corrected further.
Hope this is usefull

@brentp

brentp commented Dec 29, 2018

Copy link
Copy Markdown
Owner

I think you'd need something like:

(data != 0).sum(axis=1) > 0

but since I haven't been looking at/using this code for some time, I'd require a test before merging this.

@rvinas

rvinas commented Mar 8, 2019

Copy link
Copy Markdown

How does the original script handle constant-valued genes? I don't think it's a good practice to remove them within the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants