feat: add archived timestamp to core data models for soft-delete/hide#36
Merged
Conversation
- feat: add nullable archived column to feature_flag and feature_flag_group via migration; existing UNIQUE(name) is kept so archived names stay reserved permanently - feat: add archive(id) to FeatureFlagModel and FeatureFlagGroupModel that sets archived=now() only when null, making archiving irreversible and the timestamp immutable - feat: hide archived records from all reads by default with an includeArchived escape hatch, so archived flags evaluate as inactive while metadata is retained for audit - feat: exclude archived flags and archived groups from getSubjectMatchedFlagIds so an archived group stops contributing subject-based targeting; skip archived flags in updateAll and getFeatureFlags - feat: add archive and group-archive CLI commands plus a --include-archived flag on read commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add nullable archived column to feature_flag and feature_flag_group via migration; existing UNIQUE(name) is kept so archived names stay reserved permanently
feat: add archive(id) to FeatureFlagModel and FeatureFlagGroupModel that sets archived=now() only when null, making archiving irreversible and the timestamp immutable
feat: hide archived records from all reads by default with an includeArchived escape hatch, so archived flags evaluate as inactive while metadata is retained for audit
feat: exclude archived flags and archived groups from getSubjectMatchedFlagIds so an archived group stops contributing subject-based targeting; skip archived flags in updateAll and getFeatureFlags
feat: add archive and group-archive CLI commands plus a --include-archived flag on read commands