Fix HF agent traces analysis query to use metadata.* fields - #103
Merged
Conversation
The importer writes benchmark/harness/models/total_tokens under metadata, and the scored root spans have no metrics.tokens. Query top-level columns and metrics.tokens both fail/return null; use metadata.benchmark, metadata.harness, metadata.models, and metadata.total_tokens. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Jonathan Low (jlow2397)
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Slicing the results" query in the HuggingFaceAgentTraces cookbook read top-level
benchmark/harness/modelcolumns andmetrics.tokens, but the importer (import_logs.pyMETADATA_COLS) writes those undermetadata.*, and the scored root session spans carry the session total asmetadata.total_tokens(root spans have nometrics.tokens). As written, the query fails on missing fields / returns null token averages.Fix: use
metadata.benchmark,metadata.harness,metadata.models, andmetadata.total_tokensin SELECT and GROUP BY. Caught in review on braintrustdata/braintrust#16126.🤖 Generated with Claude Code