feat: add android 17 instrumentation test support - #139
Merged
Conversation
Dependency ReviewThe following issues were found:
Scanned Files
|
saralvasquez
marked this pull request as ready for review
July 28, 2026 23:41
mzlangreder
reviewed
Jul 29, 2026
Comment on lines
+12
to
+21
| - api-level: 31 | ||
| target: default | ||
| - api-level: 31 | ||
| target: google_apis | ||
| - api-level: 35 | ||
| target: default | ||
| - api-level: 35 | ||
| target: google_apis | ||
| - api-level: "37.0" | ||
| target: google_apis_ps16k |
There was a problem hiding this comment.
Ah this is nice, do you think we can apply this same style to our other integration tests so we can deduplicate the sections we added for Android 17 in https://github.com/braintree/braintree_android/ ?
Contributor
Author
There was a problem hiding this comment.
Yeah I think we probably can. I'll make a ticket to investigate that
mzlangreder
approved these changes
Jul 29, 2026
agedd
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adding a CHANGELOG entry isn't necessary since this is only a CI change. It also doesn't change any functionality of the repo
AI Usage
Which AI Agent Was Used?
How was AI used?
it wasn't
Estimated AI Code Contribution
Checklist
Authors