Codex tmux: deliver queued scheduler wakes on codex-owned evidence (#1006) - #1007
Conversation
olegbrok
left a comment
There was a problem hiding this comment.
Reviewed at exact head c73c61f (pre-push worktree review, full diff read): additive codex-only — zero CC production/test files touched; scheduler gate override keeps the conservative no-overlap rule on codex-owned evidence (root cause: codex sessions never emit the CC working/idle hooks the inherited gate requires); receipt mapping rides the exact-match transcript-observation contract with same-read FIFO pre-reserve; None path covered by _mark_transport_accepted's base contract; tailer on_entry callback fails loud-not-fatal with a counter. Pre-fix discriminators prove the mechanism (stale working status → 0 pastes). Full-suite single failure classified pre-existing/environmental at base (dream-transport env leak, unrelated node). Fixes the live gomez incident on the Pi (#1006). VERDICT: APPROVE (as comment — shared-account self-approve block). 🤖 Reviewed by Barsik
Summary
event_msg/user_messageentries back to the exact queued scheduler prompt and feed the existing shared positive-receipt contractuser_message→task_completesequence cannot outrun receipt associationRoot cause
The queued scheduler route uses
TmuxSession._scheduler_pane_busy, which requires fresh persisted Claude Code working/idle-hook status. Codex tmux sessions do not emit those Claude Code hooks, so a Codex agent could look fully queued in the dashboard while every trigger stalled before pane input. Ordinary direct sends used the message worker and were unaffected.Impact
This is additive and Codex-only. No shared
TmuxSession/ Claude Code production or test file changed, so the Claude Code fleet's behavior remains byte-identical. The Codex override remains fail-closed on any local overlap evidence.Validation
git diff --checkpassedtests/test_api.py::TestAPI::test_manual_dream_uses_full_persisted_conversation_history; that exact failure reproduced on detached base under the inheritedPINKY_DREAM_TRANSPORT=tmuxhost override and is unrelatedFrozen identity
9b38d63806291d6fa20a04a44b3ee38e30aa61d5c73c61f496ad5851a0abfdab38962e2094e3dc66b6ce71af837591060dacb8de07b0e49c4dbc00d8Fixes #1006
🤖 Opened by Murzik