security: resolve trusted workflow principals - #27
Conversation
Includes branch changelog.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3343d5ec5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (process.env.ENABLE_LEGACY_API === 'true') | ||
| this.app.use('/api', deprecatedApi('/api/v1'), (new API(this)).config()); |
There was a problem hiding this comment.
When ADMIN_USER_* restricts an administrative principal by tenant, groups, or model ownership, this opt-in guard disables only the runtime legacy router: /admin/api remains mounted unconditionally below, and its handlers call raw bpmnServer.definitions methods without the newly resolved principal. A client holding ADMIN_API_KEY can therefore bypass the new principal-based model authorization by using /admin/api/definitions/*; guard or remove that legacy admin router as well.
Useful? React with 👍 / 👎.
1 participant
Summary
Moves workflow identity resolution into the authenticated web integration layer.
PrincipalResolverbody.userCHANGELOG.mdStack
Depends on
refactor/canonical-api-v1(#3). This is web #4.Validation