Skip to content

refactor: separate runtime and administration clients - #40

Open
ralphhanna wants to merge 1 commit into
masterfrom
refactor/separate-admin-client
Open

refactor: separate runtime and administration clients#40
ralphhanna wants to merge 1 commit into
masterfrom
refactor/separate-admin-client

Conversation

@ralphhanna

Copy link
Copy Markdown
Collaborator

Summary

Separates pure workflow-execution requests from workflow-definition administration.

  • Keeps execution calls on the runtime client
  • Introduces explicit administration clients
  • Removes model-management methods from the runtime client contract
  • Documents the change in CHANGELOG.md

Stack

This is client #2 and the base for the canonical v1 client PR.

Validation

  • Client boundary tests pass.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3e76161356

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/BPMNAdminClient.ts
}

private checkErrors(result) {
if (result?.errors) throw new Error(result.errors);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject missing administration responses

When a request encounters a network error or any non-2xx response, WebService.invoke catches the Axios exception and resolves with undefined; this optional chain therefore treats the failed administration call as successful and lets list, delete, rename, or load resolve with undefined despite their declared return types. Make a missing result an error in this helper and in the identical BPMNAdminClient2 helper so callers can reliably detect failed administrative operations.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant