feat(annotations): correct drawing coords on rotated pages#748
Draft
kduncanhsu wants to merge 1 commit intobox:masterfrom
Draft
feat(annotations): correct drawing coords on rotated pages#748kduncanhsu wants to merge 1 commit intobox:masterfrom
kduncanhsu wants to merge 1 commit intobox:masterfrom
Conversation
When the annotation layer has a CSS rotation transform, mouse coordinates from getBoundingClientRect() are in screen space but the drawing layer interprets them in its rotated local frame. This causes live drawing to appear offset by the rotation angle. Fix by applying the inverse rotation to convert screen-space coordinates into the element local coordinate system, and use offsetWidth/offsetHeight for percentage normalization since these report pre-transform dimensions. Also removes the isRotated guard that previously blocked region creation on rotated files, enabling annotations at all rotation angles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Duncan Hsu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for live annotation drawing on rotated pages/images. This is in preparation for enabling annotation creation on rotated PDFs and images, where the annotation controls were previously hidden. Without this change, simply re-enabling annotation creation controls in the rotated state would cause the live drawing input to be offset from the user’s cursor.
This PR:
offsetWidth/offsetHeight(pre-transform dimensions) for percentage instead ofgetBoundingClientRect()which returns post-transform AABB dimensionsisRotatedguard that blocked region annotation creation on rotated filesFor further clarity, here is the live pointer capture flow when drawing annotations:
getPositionapplies the inverse rotation transform to convert screen-space coordinates into the annotation layer’s local pre-transform coordinate space (in pixels).getPoints/getShapenormalize those local-space pixel coordinates into percentages using the annotation layer’s pre-transformoffsetWidth/offsetHeight.”Test plan