Repo health: say how many repos merge on their own green, and name the two dark-factory findings - #86
Open
bdelanghe wants to merge 1 commit into
Open
Repo health: say how many repos merge on their own green, and name the two dark-factory findings#86bdelanghe wants to merge 1 commit into
bdelanghe wants to merge 1 commit into
Conversation
…e two dark-factory findings .github#390 added dark_factory per row and totals.gate_ready to the conformance snapshot, plus two findings: gate-absent (a caller whose contexts nothing on the default branch requires — green gates nothing) and arming-lane-absent (gated, but nothing arms the merge — green waits for a person). The section rendered the slugs raw and said nothing about the count. FINDING_COPY gains the two sentences. ciSummary appends "N merge on their own green (gated on the standard and the claim, with the arming lane)." only when totals.gate_ready is an integer, so a snapshot older than #390 prints nothing rather than a zero the lane never measured. Nothing re-counted. Closes #85 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAE3i1NCfwwSVYScKWvEdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85
.github#390 (.github-private#913 step 4) addeddark_factoryper row andtotals.gate_readyto the conformance snapshot, plus two findings:gate-absent(a caller whose contexts nothing on the default branch requires — green gates nothing) andarming-lane-absent(gated, but nothing arms the merge — green waits for a person). The section rendered the slugs raw and said nothing about the count.FINDING_COPYgains the two sentences.ciSummaryappends "N merge on their own green (gated on the standard and the claim, with the arming lane)." only whentotals.gate_readyis an integer — a snapshot older than #390 prints nothing rather than a zero the lane never measured; a measured zero prints as one.Tests: 359 pass (was 357) — the sentence appears only when measured, and the two findings render as sentences with no slug leaking.
This PR is itself the factory's first ordinary use here: desk carries
auto-merge.ymlsince #84, so once the claim on #85 is on the issue andpr-claimreruns, the PR's own lane arms it and it merges on green with no further click.🤖 Generated with Claude Code
https://claude.ai/code/session_01CAE3i1NCfwwSVYScKWvEdd
Generated by Claude Code