Pin ament-black to the released Python 3.14 / black>=26.3 fix (0.2.7, v0.0.12) - #2
Merged
Conversation
The dep tracked the stale noble_fix branch, whose ament_black pins black==21.12b0 + uvloop==0.17.0 (no Python 3.14 wheels) and still imports the removed black.concurrency.maybe_install_uvloop. Pin to the botsandus/ament_black#18 head commit, which fixes the import and unpins black/uvloop, so the ament_black (language: python) pre-commit hook installs and runs on Python 3.14. Repoint to @v0.2.7 (or @main) once #18 merges and 0.2.7 is released.
doisyg
force-pushed
the
pin/ament-black-py314-fix
branch
from
June 7, 2026 19:17
0a58f92 to
a81f717
Compare
doisyg
force-pushed
the
pin/ament-black-py314-fix
branch
from
June 7, 2026 19:19
a81f717 to
a7fd314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
ament_blackhook islanguage: python, so pre-commit pip-installs ament-black into a venv built with the host Python. On Python 3.14 it fails: the dependency tracked the stalenoble_fixbranch ofbotsandus/ament_black, whosesetup.pypinsblack==21.12b0+uvloop==0.17.0(no py3.14 wheels → install fails) and whosemain.pystill imports the removedblack.concurrency.maybe_install_uvloop(black renamed it tomaybe_use_uvloopin 26.3.0, psf/black#4996).Change
botsandus/ament_black#18is now merged and released as0.2.7, which:maybe_install_uvloop/maybe_use_uvloopimport fallback, andblack/uvloopinsetup.py(current black 26.x and uvloop 0.22.1 ship py3.14 wheels).Pin the dependency to the released tag
0.2.7(note: the tag has novprefix) instead of the PR head commit.Released as
0.0.12— this is the first release of the fix (v0.0.12was never tagged), so the repoint folds into that version rather than introducing a phantom0.0.13.Verified: an isolated venv install from the tag yields
ament_black 0.2.7andament_black --reformatreformats correctly on Python 3.14 with black 26.5.1.Note for consumers
Repos that pin this hook by
rev:(e.g.auto-sandbox/.pre-commit-config.yaml) should bump tov0.0.12once this is merged and taggedv0.0.12.