fix: restore xorq flavor compatibility after public ibis cleanup#282
Merged
hussainsultan merged 1 commit intoJun 30, 2026
Merged
Conversation
boringdata
force-pushed
the
julien/fix-pr278-ci-after-279
branch
from
ba43392 to
ce44763
Compare
boringdata
force-pushed
the
julien/fix-pr278-ci-after-279
branch
from
ce44763 to
79006db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_xorq.ibis) in examples and chart/demo regression paths that execute in the full xorq CI leg_xorq.ibisshim where those files are tested without xorqmake examples-coreand run it in the no-xorq CI leg so no-xorq-compatible examples are continuously exercised without xorq__bsl_prefer_known__marker lookup so ibis Deferred does not synthesize a bogus deferred resolver and crash tagged roundtripsWhy
PR #279 was merged into #278 and CI failed in two ways:
ibis.window(...)objects when applied to xorq-vendored ibis expressions (Unexpected window type: LegacyWindowBuilder) or fell back to base classification and then could not see aggregate output columns.getattr(expr, "__bsl_prefer_known__", ()); on ibis Deferred this invokes Deferred.getattr and returns another Deferred, causingTypeError: The truth value of Deferred objects is not definedin tagged roundtrip tests.The examples now use the BSL ibis shim for flavor matching, and CI explicitly runs the core examples in the no-xorq leg so they cannot silently become xorq-only again.
Validation
PYTHONPATH=src python examples/quickstart.pyPYTHONPATH=/tmp/block_xorq:src python examples/quickstart.pyPYTHONPATH=src python examples/bucketing_with_other.pyPYTHONPATH=/tmp/block_xorq:src python examples/bucketing_with_other.pyPYTHONPATH=src python examples/window_functions.pyPYTHONPATH=/tmp/block_xorq:src python examples/window_functions.pyPYTHONPATH=src python examples/sessionized_data.pyPYTHONPATH=/tmp/block_xorq:src python examples/sessionized_data.pyPYTHONPATH=src python -m pytest src/boring_semantic_layer/chart/tests/test_chart.py::TestChartWithFilters::test_chart_with_dynamic_dimension_and_rolling_window src/boring_semantic_layer/tests/test_demo_script.py::test_demo_bsl_v2_script_runs_successfully -qPYTHONPATH=/tmp/block_xorq:src python -m pytest src/boring_semantic_layer/tests/test_yaml.py::test_yaml_calculated_measures_prefer_same_named_measures src/boring_semantic_layer/chart/tests/test_chart.py::TestChartWithFilters::test_chart_with_dynamic_dimension_and_rolling_window -q