Add Perspective.js artifact integration#272
Closed
hachej wants to merge 1 commit into
Closed
Conversation
048921d to
f5b2fbe
Compare
Collaborator
Author
|
Claude Code Opus/ultracode review iteration:
Validation after fixes:
|
d6026b1 to
a5bfd99
Compare
a5bfd99 to
3e68688
Compare
Collaborator
Author
|
Closing after revisiting the Perspective integration architecture. For live app integration, Perspective can load Arrow directly or use its client/server replication model, so BSL does not need a dedicated Perspective artifact layer here. Hosts can wire BSL/Ibis Arrow outputs to Perspective without a BSL-specific manifest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kind: bsl.perspective.dataset,data) from static artifact manifests (kind: bsl.perspective.artifact,data_ref)viz-perspectiveextrascripts/test_perspective_local.pysmoke scriptTests
uv run ruff check src/boring_semantic_layer/integrations src/boring_semantic_layer/tests/test_perspective_integration.py src/boring_semantic_layer/expr.py scripts/test_perspective_local.pyuv run pytest src/boring_semantic_layer/tests/test_perspective_integration.pyuv run python scripts/test_perspective_local.pyReviews
Note: broader chart test run was attempted earlier, but optional chart dependencies (
altair/plotly/plotext) are not installed in this environment, so those unrelated tests fail withModuleNotFoundError.