Fix the template parameter name in buffers_iterator_type - #3108
Open
karpovantonme wants to merge 1 commit into
Open
Fix the template parameter name in buffers_iterator_type#3108karpovantonme wants to merge 1 commit into
karpovantonme wants to merge 1 commit into
Conversation
ashtum
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One
@tparamnaming something the template does not take.The three other
@tparamtags in this file, onbuffers_typeand its neighbours, all sayBufferSequence, so this is the odd one out rather than a convention I am changing.Not touched, in case you want it:
http/message.hpp:284documents@param argson a constructor takingArg1&& arg1, ArgN&&... argn. Describing a pack collectively reads fine to me, andclang -Wdocumentationdisagrees, so I left it as your call.