Windows 0.4.2: extensionless ade launcher for Git Bash panes - #10
Merged
Conversation
Windows agent panes default to Git Bash, and bash does not append .cmd to a bare command name — with ~/.ade\bin on PATH, `ade` exited 127 while `ade.cmd` worked. macOS has always had an extensionless launcher. createAdeCliBin now writes a second file on win32 only, generated by the existing POSIX builder with the same staged entry and the same guard exits (127 entry missing, 2 bun missing), LF-only and mode 0755 through the same writeFileIfChanged path, so every boot refreshes it. The builder now escapes the baked entry for sh's double-quoted context so a C:\... path (and any $ or backtick in it) reaches bun intact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The pipe smoke ran the launcher only through cmd.exe, so a bash pane's bare `ade` — the way ADE's own Windows terminals invoke it — was never exercised. Second leg: Git Bash, bare name resolved from the profile's bin dir, USERNAME and USER still stripped. Polls for the shim like it polls for ade.cmd, and both legs must set their marker or the step fails. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
boostedchaos
marked this pull request as ready for review
August 11, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Micro-release: bare
adein Windows bash panes.ADE's Windows agent panes default to Git Bash, and bash does not append
.cmdto a bare command name — with
~/.ade\binon PATH,adeexited 127 whileade.cmdworked. macOS has always had an extensionless launcher.Fix:
createAdeCliBinwrites<dataDir>\bin\adeon win32 in addition toade.cmd, generated by the existing POSIX builder (buildAdeBinScript) withthe same staged entry,
ADE_CLI_ENTRYoverride and guard exits (127 entrymissing, 2 bun missing). LF-only, BOM-free, mode 0755, rewritten every boot.
The builder now escapes the baked entry for sh's double-quoted context so a
C:\...path survives tobun. No other launcher gained a shim.Canary: the four new tests fail against
mainand pass here.Live on the release box, against the running installed 0.4.1 app: the real
builder wrote a shim into a temp bin dir; from a Git Bash subshell with that dir
on PATH, bare
ade list-workspacesreturned the workspace table, exit 0.Guards: missing entry (via
ADE_CLI_ENTRYand via a deleted baked entry) → 127;PATH without
bun→ 2.CI: the installed-CLI pipe smoke gains a second leg through
C:\Program Files\Git\bin\bash.exe— bareade, profile bin on PATH,USERNAME/USERstill stripped — and polls for the shim like it polls forade.cmd. Both legs must pass.Verification: server-core 489 pass / 20 skip / 0 fail (baseline 485/20/0),
pinned
tsc -p packages/server-coreexit 0, biome clean.Release prep on the branch: version 0.4.2, CHANGELOG entry, WINDOWS.md CLI
section, build-report addendum. No tag, no release — that is the gate holder's
call.