Skip to content

feat(player): add native subtitle selector - #61

Open
MagiqueDeveloper wants to merge 1 commit into
bobsupra:mainfrom
MagiqueDeveloper:feature/issue-35-subtitle-selector
Open

feat(player): add native subtitle selector#61
MagiqueDeveloper wants to merge 1 commit into
bobsupra:mainfrom
MagiqueDeveloper:feature/issue-35-subtitle-selector

Conversation

@MagiqueDeveloper

@MagiqueDeveloper MagiqueDeveloper commented Sep 6, 2026

Copy link
Copy Markdown

Summary

  • Add a captions button beside the player transport controls.
  • Use a native SwiftUI Menu for subtitle selection.
  • Group options as None, Built-In, and External Subtitles.
  • Reuse the existing subtitle-selection actions and shared option construction so the full settings panel remains consistent.

Verification

  • xcodebuild ... build — passed.
  • xcodebuild ... test -quiet — passed with exit code 0.
  • Installed and launched the app on the tvOS simulator.
  • git diff --check — passed.
  • Independent staged-diff review — passed with no security or logic findings.

Imagery

CleanShot 2026-09-06 at 11 26 27@2x CleanShot 2026-09-06 at 11 26 53@2x

Closes #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Better Subtitle Selector

1 participant