Skip to content

refactor: consolidate reveal state#355

Merged
bnema merged 1 commit into
nextfrom
refactor/reveal-state
Jul 15, 2026
Merged

refactor: consolidate reveal state#355
bnema merged 1 commit into
nextfrom
refactor/reveal-state

Conversation

@bnema

@bnema bnema commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • store pending and revealed lifecycle state as identity maps
  • preserve identity-checked replacement, release, rebuild, stale callback, and visibility serialization paths
  • add an invariant test ensuring each state entry stores its WebView identity

Validation

  • /usr/bin/go test ./internal/ui/coordinator/content -count=1
  • /usr/bin/go test -race ./internal/ui/coordinator/content -count=5
  • /usr/bin/go fmt ./...
  • make lint
  • make test
  • make staticcheck
  • /usr/bin/go vet ./...
  • make build
  • make check

Copilot AI review requested due to automatic review settings July 15, 2026 09:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ea0ff7da-f018-4829-a260-c87aa75373e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/reveal-state

Comment @coderabbitai help to get the list of available commands.

@bnema
bnema merged commit 3b318d2 into next Jul 15, 2026
5 checks passed
@bnema
bnema deleted the refactor/reveal-state branch July 15, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants