anemo: tighten Router builder ordering via typestate#12
Closed
aschran wants to merge 4 commits into
Closed
Conversation
Move route, add_rpc_service, and merge onto Router<ServicesOpen>; route_layer transitions to Router<ServicesSealed>, on which only further route_layer calls are available. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Opened against the wrong repo; recreating on MystenLabs/anemo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServicesOpen/ServicesSealedmarker types and a typestate parameter toRouter(defaultServicesOpen, so existing call sites are unaffected).route,add_rpc_service, andmergeare now defined onRouter<ServicesOpen>.route_layerconsumesRouter<ServicesOpen>and returnsRouter<ServicesSealed>; a secondroute_layerimpl onServicesSealedlets layers stack.Service<Request<Bytes>>andClone, soNetwork::startand other consumers keep working unchanged.Test plan
cargo check -p anemocargo nextest run -p anemo(74/74 pass; routing tests rewritten to cover the new shape)cargo test -p anemo --doccargo clippy --workspace --all-targetscargo fmt --all -- --check🤖 Generated with Claude Code