#12 - Build Comparison Interface#42
Merged
Merged
Conversation
krzysztofkozyra021
changed the title
EwelinaSkrzypacz
left a comment
EwelinaSkrzypacz
left a comment
Member
There was a problem hiding this comment.
-
Could we replace validation message like aroma.present.0 and aroma.present.1 with more readable field names in the validation messages?
-
Similarity Search Results -> for me tiles should be clickable and redirect to show hop page
- Comparison -> when I am on the “JSON & Visual Query” tab and select a Biochemical Property (Range) without providing values, a validation error is displayed. However, after the validation fails, I am redirected to the “Natural Language” tab. I think the user should remain on the “JSON & Visual Query” tab so the errors can be corrected more easily.👀
Collaborator
Author
Now, after the commit, You need to run a fresh migration with seed to apply the new changes, because the hops are now taken from the database |
EwelinaSkrzypacz
left a comment
EwelinaSkrzypacz
left a comment
Member
There was a problem hiding this comment.
In my opinion, fields with validation errors should be visually highlighted, for example with a red border. If possible, an error message should also be displayed below the input.
EwelinaSkrzypacz
previously approved these changes
May 20, 2026
kamilpiech97
approved these changes
Jun 3, 2026
EwelinaSkrzypacz
approved these changes
Jun 3, 2026
This was
linked to
issues
Jun 3, 2026
Closed
This was referenced Jun 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #12 and #13 and #14
Also, notice that this PR is connected with #38, so this branch was made on that branch.