Fix Conway committee ratification semantics + stale starttime in SlotConfig for transaction validation#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Yano inferred committee state from the committee member map and active member count. That made an empty but present Conway genesis committee look like no-confidence, so Yano-only devkit protocol parameter governance actions could remain active instead of enacting. Yano also always used normal
UpdateCommitteethresholds, counted committee members without hot-key authorization for min-size, and tracked devnet config had an empty committee threshold that did not match the intended no-committee-gate devkit setup.Solution
committeePresentstate, rollback-safe through boundary deltas.committeePresent=trueduring Conway genesis bootstrap andUpdateCommitteeenactment.committeePresent=falseduringNoConfidenceenactment.NORMALvsNO_CONFIDENCEfrom committee presence only, not member activity.UpdateCommitteeDRep/SPO thresholds from normal vs no-confidence threshold fields based on the post-Phase-1 committee state.0/1to pass committee approval.0/1.Tests
committeePresent.UpdateCommitteeafter no-confidence.