{184822865} Fix db:consumer() returning number on transient error#6044
Merged
emelialei88 merged 1 commit intoJun 26, 2026
Merged
Conversation
roborivers
approved these changes
Jun 25, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
…sient error Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
fix/lua-consumer-returns-number-on-error
branch
from
a6e235e to
f57cdcf
Compare
mponomar
approved these changes
Jun 26, 2026
mohitkhullar
approved these changes
Jun 26, 2026
roborivers
suggested changes
Jun 26, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**
sql_logfill_autodisable [timeout]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
luabb_trigger_register()returns the result ofluabb_error()(which is1) whencheck_retry_conditions()detects a transient error. SinceCDB2_TRIG_REQ_SUCCESS == 1, the caller skips error handling and returns the corrupted Lua stack value (-1number) instead of raising an error.luabb_error()return value and setrc = -1explicitly, so the caller's error path executes correctly.