{175900538}: Fixing stat-size misreporting#4556
Closed
riverszhang89 wants to merge 1 commit into
Closed
Conversation
roborivers
suggested changes
Jul 17, 2024
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 9/562 tests failed ⚠.
The first 10 failing tests are:
sc_timepart_logicalsc_generated
sc_resume
sc_transactional_rowlocks_generated
online_compaction
op_makerecord
unionpar_maxqueue
truncatesc
selectv_rcode
After RENAME, the file-version-cache would hold onto the old file versions, which would cause stat-size to misreport the table size. This patch fixes it. Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
riverszhang89
force-pushed
the
rename_stat_size
branch
from
04507bb to
ecdee52
Compare
roborivers
suggested changes
Jul 25, 2024
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/402 tests failed ⚠.
The first 10 failing tests are:
analyze_exit_immediately
Contributor
Author
|
see #6042 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After RENAME, the file-version-cache would hold onto the old file versions, which would cause stat-size to misreport the table size. This patch fixes it.