[codex] Fix authz, scope propagation, and shell-injection bugs#320
Open
jmecom wants to merge 8 commits intoblock:mainfrom
Open
[codex] Fix authz, scope propagation, and shell-injection bugs#320jmecom wants to merge 8 commits intoblock:mainfrom
jmecom wants to merge 8 commits intoblock:mainfrom
Conversation
Collaborator
|
@tlongwell-block this one might be good for you to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the authz, scope-propagation, and shell-injection vulnerabilities identified in the recent security review, and adds regression coverage for each fix.
What changed
Root cause
The main issue was incomplete mediation after authentication: once a caller was authenticated, several paths dropped delegated token/channel context or failed to bind the action to the specific protected resource. The desktop issue was separate: command lookup treated user-controlled input as shell syntax instead of data.
Validation