feat(desktop): register Grok Build as native ACP runtime + onboarding harness#2546
Open
Bartok9 wants to merge 2 commits into
Open
feat(desktop): register Grok Build as native ACP runtime + onboarding harness#2546Bartok9 wants to merge 2 commits into
Bartok9 wants to merge 2 commits into
Conversation
7 tasks
Author
Coordination note with Cursor PR #2536Grok Build installs both Cursor’s PR intentionally does not treat basename
|
Bartok9
force-pushed
the
bartok9/grok-build-acp-runtime
branch
from
July 23, 2026 16:36
daebcf4 to
e567b74
Compare
… harness Grok Build already speaks ACP over stdio (`grok agent stdio`) but was missing from KNOWN_ACP_RUNTIMES and the onboarding harness page. - Add grok to catalog (install, ~/.grok/bin PATH, .grok/skills, login hint) - Default args: agent --always-approve stdio for managed/headless agents - Show Grok Build on onboarding next to Claude Code and Codex - Tests + buzz-acp README Closes block#2347. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Maintainer guidance: registry uses only `grok` + agent/stdio args; never claim bare `agent` so Cursor can disambiguate the shared shim. Unit test locks that contract. README note for operators. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Bartok9
force-pushed
the
bartok9/grok-build-acp-runtime
branch
from
July 23, 2026 17:25
e567b74 to
ea75f3e
Compare
Author
Polish pass (rebased on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register Grok Build as a first-class ACP harness and show it on Set up your agent harnesses next to Claude Code and Codex.
Closes #2347. Companion: Cursor harness #2536 / #2535.
Why
Grok Build already speaks ACP natively:
grok agent stdio # managed default: grok agent --always-approve stdioWithout catalog registration, Desktop cannot discover, install-hint, or process-sweep Grok the way it does other runtimes. Onboarding also hard-filters visible harnesses (
ONBOARDING_RUNTIME_ORDER).What changed
KNOWN_ACP_RUNTIMES:grokentry (commands: grok, aliasesgrok-build/grokbuild)agent --always-approve stdio(avoids TTY tool-permission blocks for managed agents)~/.grok/bin.grok/skillslogin_hintforgrok login/XAI_API_KEY(no stableauth statusprobe in current CLI —auth_probe_args: None, same posture class as Goose)claude,codex,grokagentReadinesstreats Grok like other CLI harnesses when availablegrokbuzz-acpREADMENon-claims
grok auth statusprobe — CLI currently hasgrok login/grok auth setup, not a codex-style status subcommand.Test plan
cargo test --lib normalizes_grokcargo test --lib resolves_grokcargo test --lib grok_runtimenode --test onboardingRuntimeSelection.test.mjsgrok login/XAI_API_KEY, agent spawn usesgrok agent --always-approve stdioReviewer notes
--always-approveis intentional for managed agents (Buzz spawns without a TTY). Users who want interactive approval can override agent args.Signed-off-by: Bartok9 danielrpike9@gmail.com