Select Rustls provider in Buzz CLI#2530
Closed
colinmarsch wants to merge 1 commit into
Closed
Conversation
Combined sidecar release builds enable both Rustls backends, so auto-selection panics before a secure WebSocket connection. Install the ring provider explicitly at CLI startup. Co-authored-by: Colin Marsch <cmarsch@squareup.com> Signed-off-by: Colin Marsch <cmarsch@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When
buzz-cliis built alongside workspace crates that enable Rustls's other crypto backend, both providers are compiled and Rustls panics before the first secure WebSocket connection because it cannot select one automatically.What
ringCryptoProvider explicitly at CLI startupRisk Assessment
Low — this only makes the CLI's TLS provider selection deterministic and matches the provider already selected by other Buzz binaries.
References
cargo test -p buzz-cli— 251 tests passedCMAKE_POLICY_VERSION_MINIMUM=3.5 cargo build --release -p buzz-acp -p buzz-agent -p buzz-dev-mcp -p git-credential-nostr -p buzz-cli— exact combined sidecar build passedGenerated with Codex