Skip to content

feat(desktop): make pull request reviews actionable#2510

Open
thomaspblock wants to merge 4 commits into
mainfrom
feat/pull-request-review-polish
Open

feat(desktop): make pull request reviews actionable#2510
thomaspblock wants to merge 4 commits into
mainfrom
feat/pull-request-review-polish

Conversation

@thomaspblock

Copy link
Copy Markdown
Contributor

Summary

Pull request reviews now keep the decision and its explanation together: reviewers can comment or request changes from the same composer, approve with an optional summary, and jump from inline activity directly to the referenced diff line. Review activity is presented as a chronological timeline that starts with the latest three entries, remembers expansion choices, and keeps available lifecycle actions visible when fully collapsed.

Repository owners and their managed agents can also move pull requests between draft, open, and closed states, while source-channel metadata links the review back to the conversation that produced it. Reviewer selection, author identity, timestamps, profile previews, and project navigation have been polished to make the full review flow easier to scan and operate.

Validation

  • pnpm --dir desktop typecheck
  • Pull request review Playwright workflow, including comment-backed decisions, inline diff navigation, lifecycle controls, and remembered history state
  • Pre-push desktop checks and test suite
  • Full desktop smoke run: 663 passed and 1 skipped; the branch-related inline-review expectation was corrected and passed twice in targeted reruns. One unrelated video-attachment scenario remains flaky at varying checkpoints.

Test plan

  • Request and remove reviewers through the centered dialog
  • Submit comments, request changes, and approve with a summary
  • Open inline review activity at the referenced diff line
  • Collapse, reopen, and fully expand review history
  • Exercise draft, close, reopen, and merge controls
  • Verify source-channel navigation and granular project timestamps

Unify comments and review decisions into a navigable timeline, keep lifecycle actions available to repository owners and their managed agents, and preserve source-channel context. Polish reviewer controls, project timestamps, and code-linked review interactions for a clearer end-to-end review flow.
Show the latest three review events by default, retain per-PR expansion choices across full collapse, and make the timeline entry point easier to scan.
Expect the review timeline's new default-expanded state instead of collapsing it before checking the inline comment.
thomaspblock added a commit that referenced this pull request Jul 23, 2026
@thomaspblock

Copy link
Copy Markdown
Contributor Author

🤖 ## Screenshots

Add reviewer

The reviewer picker now opens as a centered, searchable dialog.

00-add-reviewer-dialog

Review requested

Reviewer activity appears in the chronological review timeline.

01-review-requested

Changes requested

A change request carries the reviewer's explanation and warning treatment.

05-changes-requested

Approved

Approval summaries live in the same review activity timeline.

02-approved

Draft lifecycle

Owners and managed agents can move the pull request through its lifecycle controls.

03-draft

Inline review

Inline requests include a clickable code reference that opens the relevant diff line.

04-inline-comment

@thomaspblock
thomaspblock marked this pull request as ready for review July 23, 2026 13:08
@thomaspblock
thomaspblock requested a review from a team as a code owner July 23, 2026 13:08
@thomaspblock
thomaspblock enabled auto-merge (squash) July 23, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant