Windows: preserve native PATH for Codex ACP setup#2487
Open
paritosh921 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Paritosh Mishra <paritoshm921@gmail.com>
paritosh921
force-pushed
the
fix/windows-codex-acp-path
branch
from
July 23, 2026 09:55
15a3d79 to
3e0a74c
Compare
paritosh921
marked this pull request as ready for review
July 23, 2026 10:04
Bortlesboat
reviewed
Jul 23, 2026
Bortlesboat
left a comment
There was a problem hiding this comment.
I tested this on Windows 11 at 3e0a74c.
One mechanical blocker: cargo fmt --manifest-path desktop/src-tauri/Cargo.toml --all -- --check currently exits 1 at desktop/src-tauri/src/managed_agents/runtime/path.rs:122. The root cargo fmt --all -- --check listed in the PR validation does not cover the excluded desktop crate. Please run the manifest-specific formatter and commit its one-line reflow.
Otherwise the behavior looks correct:
- Current
mainreproduced the Windows test-harness baseline (15 passed, 2 failedbecause the tests launch Unixenv); this branch passes that slice17/17withcmd /C set. - The full desktop library suite passes on the PR head (
1,440 passed, 0 failed, 9 ignored). - A clean synthetic merge with current
origin/mainpasses (1,469 passed, 0 failed, 9 ignored). - I also ran a temporary process-level Windows regression: an absolute
codex-acp.cmdshim failed to resolvenodewith a scrubbed PATH, then returned adapter major version 1 when this patch supplied the inherited native PATH.
Passing the inherited PATH explicitly into build_augmented_path is a good shape here: it keeps the behavior testable without mutating global process state and reaches both the CLI-probe and managed-agent launch paths.
Signed-off-by: Paritosh Mishra <paritoshm921@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATHwhile probing and launching managed agent commands.codex-acp.cmdnpm shim to find standard Node.js installations such asC:\Program Files\nodejs.Root cause
On Windows, Buzz avoids using the POSIX-style path returned by Git Bash. That also omitted the app's native
PATH, socodex-acp.cmdcould not resolvenode.exeduring the adapter version probe and a current adapter was reported as outdated.Validation
cargo fmt --all -- --checkcargo test -p buzz-dev-mcpcargo clippy -p buzz-dev-mcp --all-targets -- -D warningspnpm typecheckpnpm testpnpm buildFixes #2342