Show replies inside nested threads on mobile#2477
Open
BradGroux wants to merge 1 commit into
Open
Conversation
Co-authored-by: Brad Groux <bradgroux@hotmail.com> Signed-off-by: Brad Groux <bradgroux@hotmail.com>
BradGroux
marked this pull request as ready for review
July 23, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2415.
What mobile users saw
Opening a reply as the head of a nested thread showed no direct replies, even
when those replies existed on the relay.
Why it happened
ThreadDetailPageaskedthreadRepliesProviderfor relay history using thenested head ID. Relay thread history is keyed by the original root event, so the
query returned no history for that nested head.
The page already knew the effective root later in the build and already
filtered the result down to direct children. The history query was using the
wrong ID.
What changed
replies to the selected head.
R→ nested headM→ direct replyC.Regression proof
Before the production fix, the regression expected
#e == [root]and received[nested-head]. It passes with the root-scoped query.Verified at commit
970bcc4bef40bdf86d0e10a73a030b0e6731a897.Verification
just mobile-checkjust mobile-test— 529 passed, 1 skippedjust ci— Rust, Desktop, web, and mobile gates passed