chore: replace inline workflows with reusable workflow wrappers - #602
Draft
tripura-repalle wants to merge 2 commits into
Draft
chore: replace inline workflows with reusable workflow wrappers#602tripura-repalle wants to merge 2 commits into
tripura-repalle wants to merge 2 commits into
Conversation
Signed-off-by: Tripura Repalle <tripura@blinklabs.io>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+18
to
+20
| uses: blinklabs-io/actions/.github/workflows/reuseable-ci-docker.yml@main | ||
| with: | ||
| image-name: blinklabs-io/cardano-node-api |
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 https://github.com/actions/checkout/releases/tag/v6.0.3 | ||
| - uses: webiny/action-conventional-commits@7f91b1595ca1951cdb671ddc9f07a49081ec5b69 # v1.4.2 https://github.com/webiny/action-conventional-commits/releases/tag/v1.4.2 | ||
| orchestrate: | ||
| uses: blinklabs-io/actions/.github/workflows/reuseable-conventional-commits.yml@main |
| - name: go-test | ||
| run: go test ./... | ||
| orchestrate: | ||
| uses: blinklabs-io/actions/.github/workflows/reuseable-go-test.yml@main |
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@82606bf257cbaff209d206a39f5134f0cfbfd2ee # v9.2.1 https://github.com/golangci/golangci-lint-action/releases/tag/v9.2.1 | ||
| orchestrate: | ||
| uses: blinklabs-io/actions/.github/workflows/reuseable-golangci-lint.yml@main |
Comment on lines
+14
to
+16
| uses: blinklabs-io/actions/.github/workflows/reuseable-nilaway.yml@main | ||
| with: | ||
| include-pkgs: github.com/blinklabs-io/cardano-node-api |
Comment on lines
+11
to
+14
| uses: blinklabs-io/actions/.github/workflows/reuseable-test-issue-on-close.yml@main | ||
| with: | ||
| issue_number: ${{ github.event.issue.number }} | ||
| issue_title: ${{ github.event.issue.title }} |
Comment on lines
+11
to
+17
| orchestrate: | ||
| uses: blinklabs-io/actions/.github/workflows/reuseable-set-project-closed-date.yml@main | ||
| secrets: | ||
| project_pat: ${{ secrets.ORG_PROJECT_PAT }} | ||
| with: | ||
| closed_at: ${{ github.event.issue.closed_at }} | ||
| closed_date_field: Closed Date |
Dockerfile uses COPY . . and make build — changes to Makefile or openapi/** affect the image build output. Add both to the path filter so Docker CI is triggered on relevant changes. Signed-off-by: Tripura Repalle <tripura@blinklabs.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all 8 inline workflow definitions with thin wrappers calling centrally governed reusable workflows from
blinklabs-io/actions.Workflow mapping
conventional-commits.ymlreuseable-conventional-commits.yml@maingo-test.ymlreuseable-go-test.yml@main[1.25.x, 1.26.x]golangci-lint.ymlreuseable-golangci-lint.yml@mainnilaway.ymlreuseable-nilaway.yml@maininclude-pkgs: github.com/blinklabs-io/cardano-node-apici-docker.ymlreuseable-ci-docker.yml@mainimage-name: blinklabs-io/cardano-node-apipublish.ymlreuseable-publish.yml@mainbinary-name: cardano-node-api,docker-image: blinklabs/cardano-node-apitest-issue-on-close.ymlreuseable-test-issue-on-close.yml@mainupdate-issue-on-close.ymlreuseable-set-project-closed-date.yml@mainSummary by cubic
Replaced eight inline GitHub Actions with thin wrappers that call reusable workflows from
blinklabs-io/actions. This centralizes CI/CD and reduces maintenance with no behavior change; also fixes Docker CI to trigger onMakefileandopenapi/**changes.github.com/blinklabs-io/cardano-node-api; Docker CI imageblinklabs-io/cardano-node-apiand path triggers includeMakefileandopenapi/**; publish binarycardano-node-api, docker imageblinklabs/cardano-node-api, description set; project closed-date uses project 11.DOCKER_PASSWORD,ORG_PROJECT_PAT).Written for commit e501c1e. Summary will update on new commits.