fix: reject truncated encoded integers - #439
Open
wesen wants to merge 1 commit into
Open
Conversation
CascadingRadium
approved these changes
Jul 29, 2026
CascadingRadium
requested review from
a team,
CascadingRadium,
Likith101,
Samsonnyyeet,
Thejas-bhat,
capemox,
maneuvertomars and
steveyen
July 29, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return
io.ErrUnexpectedEOFwhenmemUvarintReaderreaches the end of itsinput after reading a continuation byte.
The reader previously checked for empty input only before entering its decode
loop. If the final available byte had its continuation bit set, the next loop
iteration indexed beyond the slice and panicked.
Change
Validation
go test ./...Additional resources
If you are willing to endure some slop writing, this is how I/the llm encountered the issue: https://parc.yolo.scapegoat.dev/note/projects/2026/07/28/project-report-zapx-defensive-varint-decoding-for-corrupt-bleve-postings