Fix index out of range panic when passing empty slice to NewIDSelectorBatch and NewIDSelectorBitmap - #72
Open
jizhuozhi wants to merge 1 commit into
Open
Fix index out of range panic when passing empty slice to NewIDSelectorBatch and NewIDSelectorBitmap#72jizhuozhi wants to merge 1 commit into
jizhuozhi wants to merge 1 commit into
Conversation
Avoid index out of range panic when an empty slice is passed. Pass nil pointer to C layer when len is 0 instead of accessing indices[0] or bitmap[0] which would panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewIDSelectorBatchandNewIDSelectorBitmapuse&indices[0]/&bitmap[0]to obtain the underlying data pointer for the C API call, but this panics with
index out of range [0] with length 0when an empty slice is passed.instead of attempting to take the address of the first element.