[review-mirror] M1: ADR bundle 0001-0008 (upstream nullislabs/shepherd#12) - #83
Closed
brunota20 wants to merge 3 commits into
Closed
[review-mirror] M1: ADR bundle 0001-0008 (upstream nullislabs/shepherd#12)#83brunota20 wants to merge 3 commits into
brunota20 wants to merge 3 commits into
Conversation
Updates the requirements on [wit-bindgen](https://github.com/bytecodealliance/wit-bindgen) to permit the latest version. - [Release notes](https://github.com/bytecodealliance/wit-bindgen/releases) - [Commits](bytecodealliance/wit-bindgen@v0.57.0...v0.58.0) --- updated-dependencies: - dependency-name: wit-bindgen dependency-version: 0.58.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 6.0.3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@de0fac2...df4cb1c) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Replaces the original docs/adr-bundle commit chain with the current accurate version of the same file set. Each ADR + diagram now matches the design as shipped through M5: - ADR-0001 nexum.toml -> module.toml rename - ADR-0003 32-byte hash namespacing in redb local-store - ADR-0006 capability gating is link-time (boot validation against KNOWN_CAPABILITIES), not per-call dispatch - diagrams.md ASCII hyphens per rubric; vapor features (cargo-nexum CLI, nexum-sdk separate crate, :8080/health endpoint, [module.resources] per-module caps) marked as future direction (0.3+ target), with pointers to ADR-0009 for the host-trait seam that supersedes the macro design. Same file set as before (8 ADRs in docs/adr/, 9 diagrams in docs/diagrams/, the original CI workflow + .gitignore + modules/example/Cargo.toml deltas). This is a force-push that replaces the original PR #12 head; mfw78's prior review threads will need to be re-anchored against the updated text. AI Assistance: Claude Code (Opus 4.7) rebuilt the branch by copying file content from chore/docs-reconciliation-m2-m5 (M5-current + reconciliation applied) onto a fresh tree off the upstream main base. A human (Bruno) is accountable for the result.
Author
|
Replaced by unified M1 epic mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal review mirror of upstream nullislabs#12 (M1 architectural decision records).
Scope
The eight numbered ADRs capturing the engine + CoW design decisions:
module.tomlseparate fromengine.tomlProviderPool, transport by URL scheme, fatal-on-connection-error at bootLocalStorenamespacing under a single redb file[patch.crates-io]cowprotocol tobleu/cow-rsOrderBookPoolcachedOrderBookApiper chain, built upfronttwap/ethflowhost helperscow-rs(no CoW logic in engine)SubscriptionTemplatePlus the matching diagrams under
docs/diagrams/.This branch was rebuilt to the M5-current docs state per the doc reconciliation pass (no vapor, capability gating aligned to shipped link-time enforcement).
How to use this PR