Disable read timeout for exec#179
Open
mendral-app[bot] wants to merge 2 commits into
Open
Conversation
Contributor
|
@mendral-app how about the sync method ? |
Contributor
Author
|
Good catch! I missed the sync method. I've pushed a fix — The integration test failure is unrelated (503 from httpbin.org and network timeouts in proxy tests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeout=Noneto theclient.post("/process", ...)call inexec()to preventReadTimeouton long-running sandbox processes, matching the pattern used for the streaming endpoint (PR Disable read timeout for streaming #169).Process execution time is inherently unbounded — any command could take longer than 5 minutes — so no fixed timeout is appropriate for this request.
Insight: Sandbox exec ReadTimeout on long-running processes
Note
Created by Mendral. Tag @mendral-app with feedback or questions.