Bugfix pagination not handled - #126
Merged
Merged
Conversation
stianjsu
commented
Mar 17, 2026
stianjsu
commented
Mar 17, 2026
stianjsu
commented
Mar 17, 2026
sergiosja
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pagination handling across all CRUD endpoints. The
@bp.paginate()decorator silently enforced a default page size of 10, which meant newly created events (and other entities) wouldn't show up in the frontend unless they fell within the first page. Removed the decorator entirely in favor of direct service calls with optional pagination parameters.Key additions
@bp.paginate()decorator fromevents,groups,restaurants, andslack_usersCRUD endpoints — the decorator wasn't compatible with how responses were being returnedpageandper_pageoptional (defaulting toNone) inEventService,GroupService, andRestaurantServiceso endpoints work without pagination parametersevent_timedescending inEventRepositoryso events come back in a sensible order without relying on the paginatorTESTING.mddocumenting current test coverage, known gaps, and recommendationsDockerfile.backendwith PostgreSQL client tools and addedrun-tests.shfor running tests inside DockerHow Has This Been Tested?
test_event_service,test_group_service,test_restaurant_service,test_slack_user_service) to match the new optional pagination signatures