Ntlaletsi70 patch 1 - #297
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Domain
environmentseventssourcesnetworkscommonAPI impact
v1alpha1— free to changev1beta1— backwards-compatible only, deprecations allowedv1— breaking change (requires version bump + changelog entry + migration note)Checklist
mage verifypasses locallybuf breakingreviewed (failures justified above if pre-v1)panic()calls in resolution or domain layersgen/go/blanketops/...for contract typesenvironments.blanketops.dev/*)core.SetConditionat each domain pipeline stagecore.EventRecorderfor terminal outcomesNotes for reviewer