OTWO-7710 Invaidate concurrent session when password is changed - #1932
Open
bd-vaibhav wants to merge 1 commit into
Open
OTWO-7710 Invaidate concurrent session when password is changed#1932bd-vaibhav wants to merge 1 commit into
bd-vaibhav wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the password-change flow so that changing a password invalidates other concurrent sessions by rotating the account’s remember_token, while keeping the current session authenticated.
Changes:
- Rotate
remember_tokenas part of the password update transaction, then re-sign-in to refresh the current session cookie. - Fix
valid_current_password?to return a boolean and only add an error when invalid. - Add a controller test intended to verify token rotation on successful password change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/controllers/alter_passwords_controller_test.rb | Adds coverage for remember_token rotation during password change. |
| app/models/concerns/account_validations.rb | Corrects current-password validation method to return a proper boolean result and add errors conditionally. |
| app/controllers/alter_passwords_controller.rb | Implements password update + remember-token rotation and re-authentication on success. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.